Starting to work on coroutines. - #243
Open
nicolasnoble wants to merge 16 commits into
Open
Conversation
nicolasnoble
force-pushed
the
add-coroutines
branch
from
January 16, 2025 02:53
073ace5 to
9cfc326
Compare
nicolasnoble
force-pushed
the
add-coroutines
branch
from
January 16, 2025 03:24
9cfc326 to
bd3ac04
Compare
nicolasnoble
force-pushed
the
add-coroutines
branch
from
January 16, 2025 18:14
bfc157e to
b59752b
Compare
matthewkotila
previously approved these changes
Jan 22, 2025
matthewkotila
left a comment
matthewkotila
left a comment
Contributor
There was a problem hiding this comment.
I don't comfortably understand coroutines yet but let's just see how this can be used.
Contributor
Author
|
I'm trying hard not to go "trust me bro" here, but we'll see with the next few changes as I'll work on the new scheduler next :) |
Contributor
There was a problem hiding this comment.
It looks like only a small commit of merging main into this feature branch is what's changed since my last approval, which was dismissed.
Is there anything else you'd like me to review differently from my previous approval?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a Coroutine class in the pa namespace, which we will then be able to use for a lightweight scheduler.